Split service discoverer and configurer #212
Merged
+183
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies the DefaultGrpcServiceDiscoverer by removing its dependence on the DefaultGrpcServiceConfigurer. Now the expectation is the discoverer returns a spec of the service definition rather than a bound service. The configurer then accepts that spec and binds and configures it. See spring-projects#208 Signed-off-by: Chris Bono <chris.bono@gmail.com>
onobc
commented
Jun 30, 2025
Comment on lines
-54
to
-62
| TestServiceConfigurer configurer = context.getBean(TestServiceConfigurer.class); | ||
| assertThat(configurer.invocations).hasSize(2); | ||
| assertThat(configurer.invocations.keySet()).containsExactly(SERVICE_B, SERVICE_A); | ||
| assertThat(configurer.invocations).containsEntry(SERVICE_B, null); | ||
| assertThat(configurer.invocations).hasEntrySatisfying(SERVICE_A, (serviceInfo) -> { | ||
| assertThat(serviceInfo.interceptors()).isEmpty(); | ||
| assertThat(serviceInfo.interceptorNames()).isEmpty(); | ||
| assertThat(serviceInfo.blendWithGlobalInterceptors()).isFalse(); | ||
| }); |
There was a problem hiding this comment.
This is one of the fruits of this simplification (goodbye verifying cofigurer things in discoverer tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies the DefaultGrpcServiceDiscoverer by removing its dependence on the DefaultGrpcServiceConfigurer. Now the expectation is the discoverer returns a spec of the service definition rather than a bound service. The configurer then accepts that spec and binds and configures it.
See #208