Add support for server interceptor filtering #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
force-pushed
the
GH-208-server-interceptorp-filter
branch
from
4545f1a to
9b53805
Compare
This commit adds support for filtering the server global interceptors. The server factory is now passed down through the service discoverer and configurer to allow the filter to take into account the server factory in use. The service discoverer contract has also been minimized to remove the unused `findService(String)` method. Resolves spring-projects#208 Signed-off-by: Chris Bono <chris.bono@gmail.com>
onobc
force-pushed
the
GH-208-server-interceptorp-filter
branch
from
9b53805 to
1979409
Compare
onobc
commented
Jun 29, 2025
| import io.grpc.ServerServiceDefinition; | ||
|
|
||
| /** | ||
| * Marker interface for {@link GrpcServerFactory} that is to be handled by the servlet |
There was a problem hiding this comment.
Not super excited about this but the alternative is to pass in null in this case but then the filter implementations must take this into account and check for null and then assume null means servlet.
onobc
commented
Jun 29, 2025
| * @return list of service names - empty when no services available | ||
| */ | ||
| default List<String> listServiceNames() { |
There was a problem hiding this comment.
Because listing of service names should not need to deal w/ any interceptors etc.. I broke this out into its own impl as it was just piggy-backing off of findServices out of convenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning
WIP
This is being reworked once #212 is merged
This commit adds support for filtering the server-side global interceptors.
The server factory is now passed down through the service discoverer and configurer to allow the filter to take into account the server factory in use.
The service discoverer contract has also been minimized to remove the unused
findService(String)method.Resolves #208