Skip to content

Fixed anthropic stream not return finish reason #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Fixed anthropic stream not return finish reason #1401

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d9ea86
Now if it has finishReason but not has content it send finishReason w…
Claudio-code Sep 24, 2024
19ab95f
fixed test
Claudio-code Sep 24, 2024
0fb3c9f
Adjusted to use mutable list
Claudio-code Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions ...pring-ai-anthropic/src/main/java/org/springframework/ai/anthropic/AnthropicChatModel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,16 +282,22 @@ private ChatResponse toChatResponse(ChatCompletionResponse chatCompletion) {
}

List<Generation> generations = chatCompletion.content()
.stream()
.filter(content -> content.type() != ContentBlock.Type.TOOL_USE)
.map(content -> {
return new Generation(new AssistantMessage(content.text(), Map.of()),
ChatGenerationMetadata.from(chatCompletion.stopReason(), null));
})
.toList();
.stream()
.filter(content -> content.type() != Type.TOOL_USE)
.map(content -> {
return new Generation(new AssistantMessage(content.text(), Map.of()),
ChatGenerationMetadata.from(chatCompletion.stopReason(), null));
})
.toList();

List<Generation> allGenerations = new ArrayList<>(generations);

if (chatCompletion.stopReason() != null && generations.isEmpty()) {
Generation generation = new Generation(new AssistantMessage(null, Map.of()),
ChatGenerationMetadata.from(chatCompletion.stopReason(), null));
allGenerations.add(generation);
}

List<ContentBlock> toolToUseList = chatCompletion.content()
.stream()
.filter(c -> c.type() == ContentBlock.Type.TOOL_USE)
Expand Down
2 changes: 1 addition & 1 deletion ...ropic/src/test/java/org/springframework/ai/anthropic/AnthropicChatModelObservationIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ void observationForStreamingChatOperation() {
ChatResponseMetadata responseMetadata = lastChatResponse.getMetadata();
assertThat(responseMetadata).isNotNull();

validate(responseMetadata, KeyValue.NONE_VALUE);
validate(responseMetadata, "[\"end_turn\"]");
}

private void validate(ChatResponseMetadata responseMetadata, String finishReasons) {
Expand Down