Skip to content

Fixed anthropic stream not return finish reason #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Claudio-code
Copy link
Contributor

@Claudio-code Claudio-code commented Sep 24, 2024

Thank you for taking time to contribute this pull request!
You might have already read the [contributor guide][1], but as a reminder, please make sure to:

Fixed it issue #1248

  • Sign the contributor license agreement
  • Rebase your changes on the latest main branch and squash your commits
  • Add/Update unit tests as needed
  • Run a build and make sure all tests pass prior to submission

@tzolov
Copy link
Contributor

tzolov commented Sep 24, 2024

Hi @Claudio-code , thank you for catching and fixing the case when we have empty generation list.

@tzolov tzolov self-assigned this Sep 24, 2024
@tzolov tzolov added bug Something isn't working anthropic chat client labels Sep 24, 2024
@tzolov tzolov added this to the 1.0.0-M3 milestone Sep 24, 2024
@tzolov
Copy link
Contributor

tzolov commented Sep 24, 2024

Rebased, squashed and merged at b468354

@tzolov tzolov closed this Sep 24, 2024
@Claudio-code Claudio-code deleted the fixed-anthropic-stream-not-return-finish-reason branch September 24, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
anthropic bug Something isn't working chat client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants