Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Lint Errors due to latest Lint upgrade #614

Closed
ghillert opened this issue Feb 5, 2018 · 2 comments · Fixed by #628
Closed

Fix Lint Errors due to latest Lint upgrade #614

ghillert opened this issue Feb 5, 2018 · 2 comments · Fixed by #628
Assignees
@ghillert
Labels
type/technical-debt Techical Dept
Milestone
1.4.0.M1

Comments

@ghillert
Copy link
Contributor

ghillert commented Feb 5, 2018 •
edited
Loading

Also consider implementing https://github.com/cartant/rxjs-tslint-rules to provide more detailed linting in regards to RxJS.

Depends on #534

This issue will fix Lint errors - Lint warnings will be addressed by #536
@ghillert ghillert added this to the 1.4.0.M1 milestone Feb 5, 2018
@ghillert ghillert mentioned this issue Feb 5, 2018
Closed
@sabbyanandan sabbyanandan modified the milestones: 1.4.0.M1, 1.4.0.RC1 Feb 7, 2018
@sabbyanandan sabbyanandan mentioned this issue Feb 11, 2018
Closed
@oodamien oodamien self-assigned this Feb 12, 2018
oodamien added a commit to oodamien/spring-cloud-dataflow-ui that referenced this issue Feb 12, 2018
@oodamien
Fix Lint Errors
b4236eb 
Resolve spring-cloud#614
@oodamien
Copy link
Member

oodamien commented Feb 13, 2018 •
edited
Loading

Frist investigations:

  • Minor: fix typo (use --fix)
  • Http Deprecated: migrate to HttpClient

@ghillert ghillert assigned ghillert and unassigned oodamien Feb 14, 2018
@ghillert ghillert changed the title Polish Lint Errors due to latest Lint upgrade Fix Lint Errors due to latest Lint upgrade Feb 14, 2018
@ghillert ghillert mentioned this issue Feb 14, 2018
Merged
@ghillert ghillert added in pr and removed ready labels Feb 14, 2018
@ghillert
Copy link
Contributor Author

ghillert commented Feb 15, 2018 •
edited
Loading

Rebased and polished

@oodamien oodamien assigned oodamien and ghillert and unassigned ghillert and oodamien Feb 15, 2018
oodamien pushed a commit that referenced this issue Feb 15, 2018
@ghillert @oodamien
gh-614 Fix Lint Errors due to latest Lint upgrade
ff6d1f2
@sabbyanandan sabbyanandan modified the milestones: 1.4.0.RC1, 1.4.0.M1 Feb 16, 2018
@sabbyanandan sabbyanandan added the type/technical-debt Techical Dept label Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghillert ghillert

Labels
type/technical-debt Techical Dept
Projects
None yet
Milestone
1.4.0.M1
Development

Successfully merging a pull request may close this issue.

gh-614 Fix Lint Errors due to latest Lint upgrade
3 participants
@oodamien @ghillert @sabbyanandan