Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace HttpModule with HttpClientModule #536

Closed
cppwfs opened this issue Nov 7, 2017 · 3 comments · Fixed by #859
Closed

Replace HttpModule with HttpClientModule #536

cppwfs opened this issue Nov 7, 2017 · 3 comments · Fixed by #859
Assignees
@ghillert
Labels
type/technical-debt Techical Dept
Milestone
1.7.0.M1

Comments

@cppwfs
Copy link
Contributor

cppwfs commented Nov 7, 2017

After migrating to Angular 5 we need to replace HttpModule with HttpClientModule. Because HttpModule will be deprecated.
https://blog.angular.io/version-5-0-0-of-angular-now-available-37e414935ced
@cppwfs cppwfs mentioned this issue Nov 7, 2017
Closed
@ghillert ghillert added this to the 1.4.0.M1 milestone Feb 5, 2018
@sabbyanandan
Copy link
Contributor

@ghillert: Is this already covered in the Angular5 PR? Perhaps close this as a duplicate if so?

@sabbyanandan
Copy link
Contributor

@ghillert: Thoughts?

@sabbyanandan sabbyanandan modified the milestones: 1.4.0.M1, 1.5.0.M1 Feb 11, 2018
@ghillert ghillert mentioned this issue Feb 14, 2018
Closed
@sabbyanandan sabbyanandan removed this from the 1.5.0.M1 milestone Apr 12, 2018
@ghillert ghillert mentioned this issue Jun 27, 2018
Closed
@ghillert
Copy link
Contributor

Due to #832 we should migrate to the HttpClientModule as soon as possible.

@sabbyanandan sabbyanandan added this to the 1.6.0.RC1 milestone Jun 27, 2018
@sabbyanandan sabbyanandan added the type/technical-debt Techical Dept label Jul 16, 2018
@ghillert ghillert mentioned this issue Jul 17, 2018
Merged
@sabbyanandan sabbyanandan modified the milestones: 1.6.0.RC1, 1.7.0.M1 Jul 20, 2018
oodamien pushed a commit that referenced this issue Jul 27, 2018
@ghillert @oodamien
gh-536 Replace HttpModule with HttpClientModule
9fbee39 
* Update Tests (Refactoring of HttpClient mocks)
* Ensure that lint warnings related to Http module are fixed
* Minor fix to make bundle analyzer work: Update `webpack-bundle-analyzer` to `2.13.1`
* Fix RxJS lint warnings due to deprecation
* Start to Remove unused imports
* Fix Lint errors
@oodamien oodamien removed the in pr label Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ghillert ghillert

Labels
type/technical-debt Techical Dept
Projects
None yet
Milestone
1.7.0.M1
Development

Successfully merging a pull request may close this issue.

gh-536 Replace HttpModule with HttpClientModule
4 participants
@oodamien @ghillert @cppwfs @sabbyanandan