This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Polish Secrets Manager Integration #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `spring-boot` 2.4, `Volume Mounted Config Directory Trees` was added. This commit introduces the prefix `aws-secretsmanager:` which will resolve the values given the configuration properties supported by secrets manager integration. Also, if keys are added after the prefix then just these will be resolved. Use: `aws-secretsmanager:` or `aws-secretsmanager:my-secret-key` or `aws-secretsmanager:my-secret-key;my-anoter-secret-key` Closes gh-655
…org/springframework/cloud/aws/autoconfigure/secretsmanager/AwsSecretsManagerConfigDataLocationResolver.java Co-authored-by: Maciej Walkowiak <walkowiak.maciej@yahoo.com>
- fixed handling failFast and optional flag - added logs - added tests
github-actions
bot
added
component: secrets-manager
eddumelendez
reviewed
Dec 8, 2020
eddumelendez
suggested changes
Dec 8, 2020
...org/springframework/cloud/aws/secretsmanager/AwsSecretsManagerPropertySourceLocatorTest.java
Outdated
Show resolved
Hide resolved
...org/springframework/cloud/aws/secretsmanager/AwsSecretsManagerPropertySourceLocatorTest.java
Outdated
Show resolved
Hide resolved
eddumelendez
approved these changes
Dec 8, 2020
|
That's me losing the battle with git and intellij |
maciejwalkowiak
added a commit
to awspring/spring-cloud-aws
that referenced
this pull request
Dec 19, 2020
- fixed handling failFast and optional flag - added logs - added tests
juho9000
pushed a commit
to juho9000/spring-cloud-aws
that referenced
this pull request
Apr 29, 2021
- fixed handling failFast and optional flag - added logs - added tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Correct handling
optionalconfig data andfailFastfor old type of integration.Fixes logging in
AwsSecretsManagerConfigDataLocationResolver.Handles the case when
AwsSecretsManagerPropertySourcesreturnsnull.💡 Motivation and Context
Follow up to #721.
💚 How did you test it?
Unit & integration tests.
📝 Checklist