This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Add aws-secretsmanager: prefix config import #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: secrets-manager
In `spring-boot` 2.4, `Volume Mounted Config Directory Trees` was added. This commit introduces the prefix `aws-secretsmanager:` which will resolve the values given the configuration properties supported by secrets manager integration. Also, if keys are added after the prefix then just these will be resolved. Use: `aws-secretsmanager:` or `aws-secretsmanager:my-secret-key` or `aws-secretsmanager:my-secret-key;my-anoter-secret-key` Closes spring-atticgh-655
maciejwalkowiak
suggested changes
Nov 24, 2020
There was a problem hiding this comment.
Great work @eddumelendez! I left few comments - we need to figure out the proper handling of optional config data import.
Btw, Vault integration could be helpful reference for us in general for this feature: spring-cloud/spring-cloud-vault@451ccb0
It would be great if you could add Javadocs but they can be also added later. Once this one is merged I will create a PR with a sample that I did to verify how/if it works.
|
|
||
| However, starting at `spring-cloud-aws` `2.3`, allows import default aws' secretsmanager keys | ||
| (`spring.config.import=aws-secretsmanager:`) or individual keys | ||
| (`spring.config.import=aws-secretsmanager:secret-key;other-secret-key`) |
There was a problem hiding this comment.
It would be nice to document that it can be used with optional prefix.
...pringframework/cloud/aws/autoconfigure/secretsmanager/AwsSecretsManagerConfigDataLoader.java
Show resolved
Hide resolved
...pringframework/cloud/aws/autoconfigure/secretsmanager/AwsSecretsManagerConfigDataLoader.java
Show resolved
Hide resolved
...work/cloud/aws/autoconfigure/secretsmanager/AwsSecretsManagerConfigDataLocationResolver.java
Outdated
Show resolved
Hide resolved
11 tasks
…org/springframework/cloud/aws/autoconfigure/secretsmanager/AwsSecretsManagerConfigDataLocationResolver.java Co-authored-by: Maciej Walkowiak <walkowiak.maciej@yahoo.com>
...ava/org/springframework/cloud/aws/secretsmanager/AwsSecretsManagerPropertySourceLocator.java
Show resolved
Hide resolved
|
|
maciejwalkowiak
approved these changes
Dec 2, 2020
9 tasks
maciejwalkowiak
added a commit
to awspring/spring-cloud-aws
that referenced
this pull request
Dec 19, 2020
…ud-aws#721) In `spring-boot` 2.4, `Volume Mounted Config Directory Trees` was added. This commit introduces the prefix `aws-secretsmanager:` which will resolve the values given the configuration properties supported by secrets manager integration. Also, if keys are added after the prefix then just these will be resolved. Use: `aws-secretsmanager:` or `aws-secretsmanager:my-secret-key` or `aws-secretsmanager:my-secret-key;my-anoter-secret-key` Closes spring-attic/spring-cloud-aws#655 Closes spring-attic/spring-cloud-aws#515 Co-authored-by: Maciej Walkowiak <walkowiak.maciej@yahoo.com>
juho9000
pushed a commit
to juho9000/spring-cloud-aws
that referenced
this pull request
Apr 29, 2021
…ud-aws#721) In `spring-boot` 2.4, `Volume Mounted Config Directory Trees` was added. This commit introduces the prefix `aws-secretsmanager:` which will resolve the values given the configuration properties supported by secrets manager integration. Also, if keys are added after the prefix then just these will be resolved. Use: `aws-secretsmanager:` or `aws-secretsmanager:my-secret-key` or `aws-secretsmanager:my-secret-key;my-anoter-secret-key` Closes spring-attic/spring-cloud-aws#655 Closes spring-attic/spring-cloud-aws#515 Co-authored-by: Maciej Walkowiak <walkowiak.maciej@yahoo.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
spring-boot2.4,Volume Mounted Config Directory Treeswasadded. This commit introduces the prefix
aws-secretsmanager:whichwill resolve the values given the configuration properties supported
by secrets manager integration. Also, if keys are added after the
prefix then just these will be resolved.
Use:
aws-secretsmanager:oraws-secretsmanager:my-secret-keyoraws-secretsmanager:my-secret-key;my-anoter-secret-keyCloses gh-655
Closes gh-515