This repository was archived by the owner on Aug 12, 2024. It is now read-only.
Merged
Conversation
Member
pettermahlen
left a comment
pettermahlen
left a comment
There was a problem hiding this comment.
Partial review - didn't have time to check the tests yet, but I have some questions.
src/main/java/com/spotify/dns/ServiceResolvingChangeNotifier.java
Outdated
Show resolved
Hide resolved
pettermahlen
approved these changes
Mar 16, 2020
This was referenced Mar 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was prompted by me trying to modularize another library that transitively dependeds on
dns-java. I ran into an issue when importing this as an automatic module, caused bydnsjavacontaining classes in the default/unnamed package:These are removed in version 3.0.0
Upgrading dnsjava to 3.x
Although the readme mentions that a lot of things has changed, we seem to be in the clear since we're using such a small portion of the API (
Lookup,RecordandSRVRecord)Upgrade to Java 9
Java 9 was released September 2017. It should not be a controversial requirement. Also, given the level of stability in this library, it would be safe to continue using v3.1.5 for users still on Java 8.
Dropping jsr305
The value of these annotations where minimal. A small price to pay for enabling modules. cc #33
This PR should make #36 redundant