This repository was archived by the owner on Aug 12, 2024. It is now read-only.
Automatic-Module-Name added to the manifest.#36
Closed
TheIndifferent wants to merge 1 commit intospotify:masterfrom
TheIndifferent:automatic-module-names
Closed
Automatic-Module-Name added to the manifest.#36TheIndifferent wants to merge 1 commit intospotify:masterfrom TheIndifferent:automatic-module-names
TheIndifferent wants to merge 1 commit intospotify:masterfrom
TheIndifferent:automatic-module-names
Conversation
|
Would it be possible to make a release with automatic module name set? |
Merged
Contributor
|
This should be redundant given the proper module declaration in #38 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As described by http://branchandbound.net/blog/java/2017/12/automatic-module-name/ , adding
Automatic-Module-Nameallows us to move to Java 11 without worrying that the jar file name will change.