Upgrade to Swift 5 and apply Xcode fixes #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manucheri
reviewed
Aug 9, 2019
Codecov Report
@@ Coverage Diff @@
## master #35 +/- ##
=======================================
Coverage 96.29% 96.29%
=======================================
Files 36 36
Lines 864 864
=======================================
Hits 832 832
Misses 32 32Continue to review full report at Codecov.
|
dflems
previously approved these changes
Aug 9, 2019
JensAyton
suggested changes
Aug 9, 2019
Package.swift
Outdated
| .package(url: "https://github.com/Quick/Nimble", .upToNextMajor(from: "7.0.0")), | ||
| .package(url: "https://github.com/Quick/Quick", .upToNextMinor(from: "1.2.0")), | ||
| .package(url: "https://github.com/Quick/Nimble", from: "8.0.0"), | ||
| .package(url: "https://github.com/Quick/Quick", from: "2.0.0"), |
There was a problem hiding this comment.
I believe this should be from: "2.1.0", since Carthage users are free to start depending on hypothetical 2.1 features
| .testTarget(name: "MobiusTestTests", dependencies: ["MobiusTest", "Quick"], path: "MobiusTest/Test"), | ||
| ], | ||
| swiftLanguageVersions: [.v4_2] | ||
| swiftLanguageVersions: [.v5] |
There was a problem hiding this comment.
[.v4_2, .v5] for consistency?
There was a problem hiding this comment.
Why is that? This Package.swift will be used when targeting Swift 5, and Package@swift-4.2.swift when targeting Swift 4.2
JensAyton
approved these changes
Aug 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mobius.swift is using a pretty old version of Quick and Nimble which is causing SPM to not resolve the dependency graph in some cases (for example when used to together with XCLogParser which uses Commandant which itself has a dependency on Quick 2.0.0 and Nimble 8.0.0). For this reason, it's good to move to the newer versions.
I took the opportunity to also update to Swift 5 and apply all Xcode 10.2.1 suggested fixes in4d5d5bc.
Update: Turns out these changes are not needed at all, it probably was a temporary Xcode glitch.
Note: the new version of Quick that we have updated to has some warnings that are still unresolved (Quick/Nimble#661).Update: These warnings don't show up anymore on my machine for some reason, even better.