Skip to content

Conversation

@freak4pc
Copy link

@freak4pc freak4pc commented Jun 1, 2019

Hey there! :)
The project has Matcher deprecations for a while, but many methods and classes using Matcher aren't market as deprecated. This causes manny inner warnings inside Nimble itself.

For consumers using SPM there's no real way to turn this off.

image

I've marked all consumers of Matcher as deprecated themselves to resolve this.

Copy link
Member

@ikesyo ikesyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this! Those deprecation are planned as stated in the README. But some of them seem not correct to me.

@freak4pc
Copy link
Author

freak4pc commented Jun 1, 2019

Thanks @ikesyo - I'm a bit confused on how it could be possible (theoretically / puristically speaking) to deprecate a type that has non-deprecated methods counting on it?

If there is a method X that counts on type Y and the former isn't deprecated, it makes sense the latter isn't as well. So, does this really make sense having Matcher completely deprecated in this sense?

@mthormann-dhi
Copy link

Any update on this?

@ikesyo
Copy link
Member

ikesyo commented May 14, 2020

Superseded by #746.

@ikesyo ikesyo closed this May 14, 2020
@freak4pc
Copy link
Author

Always fun having a different PR supersede yours that wasn't reviewed for almost a year... Oh well :)

@freak4pc freak4pc deleted the deprecations branch May 14, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants