Skip to content

Bugfix: prevent spk build failing if completed builds disk usage calcs error #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Bugfix: prevent spk build failing if completed builds disk usage calcs error #1280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03dff77
Bugfix for spk pip converted source builds that contain no files and …
dcookspi Oct 8, 2025
be659f3
Fixing up comments
dcookspi Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions crates/spk-cli/cmd-build/src/cmd_build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,9 @@ impl Run for Build {
current_package_version,
&idents,
)
.await?;
.await
.unwrap_or(0);

total_packages_size += version_builds_size;
self.print_total_size(current_package_version, version_builds_size)
.await;
Expand All @@ -181,7 +183,9 @@ impl Run for Build {

// Build sizes are calculated separately because we want
// to show the disk usage of each build on its own.
let size = spk_storage::get_build_disk_usage(&repos, ident).await?;
let size = spk_storage::get_build_disk_usage(&repos, ident)
.await
.unwrap_or(0);

// This total will include some double counting in some packages
total_builds_size += size;
Expand All @@ -196,7 +200,9 @@ impl Run for Build {
current_package_version,
&idents,
)
.await?;
.await
.unwrap_or(0);

total_packages_size += version_builds_size;
self.print_total_size(current_package_version, version_builds_size)
.await;
Expand Down
6 changes: 6 additions & 0 deletions crates/spk-storage/src/disk_usage.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -639,6 +639,12 @@ pub async fn get_version_builds_disk_usage(

/// A helper to return the disk usage in bytes of the given build (all
/// components) in the given repo(s).
///
/// Note: builds with no files (at all) will return a
/// DiskUsageBuildNotFound error because at least one file is needed to
/// calculate a walked disk usage entry. For example, commands like
/// 'spk convert pip ...' can generate /src builds for python
/// packages that have no files in them.
pub async fn get_build_disk_usage(
repos: &Vec<(String, RepositoryHandle)>,
build_ident: &BuildIdent,
Expand Down
Loading