Bugfix: prevent spk build failing if completed builds disk usage calcs error #1280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…so have no size Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
rydrman
approved these changes
Oct 8, 2025
jrray
requested changes
Oct 9, 2025
crates/spk-storage/src/disk_usage.rs
Outdated
| /// components) in the given repo(s). | ||
| /// | ||
| /// Note: builds with no files (at all) will return a | ||
| /// DiskUsageBuildNotFound error because at least on file is needed to |
There was a problem hiding this comment.
Suggested change
| /// DiskUsageBuildNotFound error because at least on file is needed to | |
| /// DiskUsageBuildNotFound error because at least one file is needed to |
There was a problem hiding this comment.
Though IMO it should return a success of 0 rather than "build not found" in this case. I don't consider this situation an error, and the error name doesn't fit the situation.
There was a problem hiding this comment.
Yes, it is not intuitive returning "build not found" when it clearly is present, it just has no files on disk to get disk usage sizes from.
crates/spk-storage/src/disk_usage.rs
Outdated
| /// Note: builds with no files (at all) will return a | ||
| /// DiskUsageBuildNotFound error because at least on file is needed to | ||
| /// calculate a walked disk usage entry. For example, commands like | ||
| /// 'spk pip convert ...' can generate /src builds for python |
There was a problem hiding this comment.
Suggested change
| /// 'spk pip convert ...' can generate /src builds for python | |
| /// 'spk convert pip ...' can generate /src builds for python |
There was a problem hiding this comment.
I've updated this and the one above.
Signed-off-by: David Gilligan-Cook <dcook@imageworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that causes
spk buildcommands to appear to fail when gather disk usage encounters an error during the "Completed builds: ..." output at the end of thespk build. The builds haven't failed, but the command errors out. The fix is to catch the disk uage error and use zero size for that build (or version).The situation can happen when using
spk pip conver ...on a python module. The generated (placeholder) source build for the python module contains no files in its component layers, and thus nothing to measure for disk usage, which generates a disk usage error.