Emit events when Node Selectors are set #5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
faisal-memon
changed the title
azdagron
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Thanks, @faisal-memon. Looks like the delete case is already covered by DeleteAttestedNode.
|
@amartinezfayo This got bumped from merge, likely due to the need to remerge the main into it with #5030 and other changes. Can you revisit this before the maintainer's meeting so we can save a bit of meeting time? |
rushi47
pushed a commit
to rushi47/spire
that referenced
this pull request
Apr 11, 2024
Signed-off-by: Faisal Memon <fymemon@yahoo.com> Co-authored-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Events based cache
Description of change
When node selecors are added/modified/deleted we aren't emitting events currently. This change sets an event when node selectors are set.