Fix event being dropped on error #5030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
faisal-memon
requested review from
evan2645,
amartinezfayo,
azdagron,
MarcosDY and
rturner3
as code owners
|
I think we're missing a spot where we need to set the event as handled in the "agent has expired" case. Is there a way this can be refactored so that it's clear the "last handled ID" is being set in all non-error cases? |
Signed-off-by: Faisal Memon <fymemon@yahoo.com>
Thanks for catching that. Updated. The "agent has expired" block of code will be removed as part of the change set to properly handling pruning expired agents. That should clean up this function a bit. |
azdagron
approved these changes
Apr 4, 2024
3 tasks
rushi47
pushed a commit
to rushi47/spire
that referenced
this pull request
Apr 11, 2024
* Fix event being dropped on error Signed-off-by: Faisal Memon <fymemon@yahoo.com> * Fix missing event id bump Signed-off-by: Faisal Memon <fymemon@yahoo.com> --------- Signed-off-by: Faisal Memon <fymemon@yahoo.com> Co-authored-by: Andrew Harding <azdagron@gmail.com> Co-authored-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check list
Affected functionality
Events based cache
Description of change
We are marking the event as being process before the call to
GetNodeSelectors(). If that call errors then the event will not retried and be skipped over.