Add 1.7.1 and v1.6.5 to the Changelog #4347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
requested review from
evan2645,
azdagron,
MarcosDY and
rturner3
as code owners
azdagron
approved these changes
Jul 20, 2023
CHANGELOG.md
Outdated
|
|
||
| ### Changed | ||
|
|
||
| - Improvement in entry lookup logic when fetching JWT-SVIDs (#4211) |
There was a problem hiding this comment.
I dunno if this is worth mentioning since it is more or less just a code maintenance improvement?
There was a problem hiding this comment.
If it translates into a meaningful perf benefit, we could say something like "reduced CPU/memory usage when fetching JWT-SVIDs"
There was a problem hiding this comment.
It will probably not be a noticeable perf improvement in most cases. I'm now more inclined to remove this.
evan2645
reviewed
Jul 20, 2023
CHANGELOG.md
Outdated
|
|
||
| ### Fixed | ||
|
|
||
| - Bug distinguishing audience sets in the agent's JWT-SVID cache (#4309) |
There was a problem hiding this comment.
We should probably be talking about user impact here, e.g.
- SPIRE Agent cache bug resulting in workloads receiving JWT-SVIDs with incomplete audience set
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
evan2645
approved these changes
Jul 27, 2023
amartinezfayo
changed the title
amartinezfayo
added a commit
to amartinezfayo/spire
that referenced
this pull request
Jul 28, 2023
* Add 1.7.1 and v1.6.5 to the Changelog Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
added a commit
that referenced
this pull request
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 1.7.1 to the Changelog.