Allow digitalSignature key usage on signing certs #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out `aws_pca` sets digitalSignature on subordinate certificates. The browser forum also has digitalSignature as a minimum requirement for CAs that sign OCSP responses. Fixes: spiffe#4351 Signed-off-by: Andrew Harding <azdagron@gmail.com>
azdagron
requested review from
evan2645,
amartinezfayo,
MarcosDY and
rturner3
as code owners
evan2645
approved these changes
Jul 26, 2023
amartinezfayo
added a commit
to amartinezfayo/spire
that referenced
this pull request
Jul 26, 2023
Signed-off-by: Agustín Martínez Fayó <amartinezfayo@gmail.com>
amartinezfayo
pushed a commit
to amartinezfayo/spire
that referenced
this pull request
Jul 27, 2023
Turns out `aws_pca` sets digitalSignature on subordinate certificates. The browser forum also has digitalSignature as a minimum requirement for CAs that sign OCSP responses. Fixes: spiffe#4351 Signed-off-by: Andrew Harding <azdagron@gmail.com> Co-authored-by: Evan Gilman <evan@spirl.com>
amartinezfayo
pushed a commit
to amartinezfayo/spire
that referenced
this pull request
Jul 27, 2023
Turns out `aws_pca` sets digitalSignature on subordinate certificates. The browser forum also has digitalSignature as a minimum requirement for CAs that sign OCSP responses. Fixes: spiffe#4351 Signed-off-by: Andrew Harding <azdagron@gmail.com> Co-authored-by: Evan Gilman <evan@spirl.com>
amartinezfayo
added a commit
that referenced
this pull request
Jul 27, 2023
Turns out `aws_pca` sets digitalSignature on subordinate certificates. The browser forum also has digitalSignature as a minimum requirement for CAs that sign OCSP responses. Fixes: #4351 Signed-off-by: Andrew Harding <azdagron@gmail.com>
amartinezfayo
added a commit
that referenced
this pull request
Jul 27, 2023
Turns out `aws_pca` sets digitalSignature on subordinate certificates. The browser forum also has digitalSignature as a minimum requirement for CAs that sign OCSP responses. Fixes: #4351 Signed-off-by: Andrew Harding <azdagron@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out
aws_pcasets digitalSignature on subordinate certificates.The browser forum also has digitalSignature as a minimum requirement for CAs that sign OCSP responses.
Fixes: #4351