Merged
Conversation
Contributor
Summary
Previous Results
Insights
Slowest Tests
🎉 No failed tests in this run. | 🍂 No flaky tests in this run. Github Test Reporter by CTRF 💚 🔄 This comment has been updated |
KCarretto
previously approved these changes
Jan 14, 2026
Collaborator
KCarretto
left a comment
KCarretto
left a comment
There was a problem hiding this comment.
Would appreciate a small change but otherwise lgtm
| eldritch-macros = { workspace = true } | ||
| eldritchv2 = { workspace = true, features = ["std", "stdlib"] } | ||
| eldritch-repl = { workspace = true } | ||
| # Need fake here so we import this on its own |
Collaborator
There was a problem hiding this comment.
we propagate feature flags, so this should be eldritchv2 = { workspace = true, features = ["std", "stdlib", "fake_bindings"] } and then ensure eldritchv2 correctly propagates the feature flag to the stdlib crates (I think it already does). If we don't want all of the fake impls, I would add a feature flag fake_<lib> to eldritchv2 to allow it to be built with only that fake binding.
KCarretto
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move all v2 imports behind the v2 library