Skip to content

Comments

Add jwt keys#1546

Merged
hulto merged 26 commits intomainfrom
add-jwt-keys
Jan 15, 2026
Merged

Add jwt keys#1546
hulto merged 26 commits intomainfrom
add-jwt-keys

Conversation

@hulto
Copy link
Collaborator

@hulto hulto commented Jan 8, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:

  • Adds a JWT to claim tasks API
  • Agent passes jwt to report and fetch calls
  • Server verifies JWT is not valid
  • For now warns when invalid will error when imixv1 is removed.

Which issue(s) this PR fixes:

Fixes #

@hulto hulto requested a review from KCarretto January 8, 2026 02:21
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

Summary

Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
3029    ±0 3029    ±0 0    ±0 0    ±0 0    ±0 0    ±0 1ms    ±0

Previous Results

Build 🏗️ Result 🧪 Tests 📝 Passed ✅ Failed ❌ Skipped ⏭️ Other ❓ Flaky 🍂 Duration ⏱️
#480 3029 3029 0 0 0 0 29.4s

Insights

Average Tests per Run Total Flaky Tests Total Failed Slowest Test (p95)
3029 0 0 10.3s

Slowest Tests

Test 📝 Results 📊 Duration (avg) ⏱️ Duration (p95) ⏱️
imixv2::bin/imixv2: tests::task_tests::test_task_streaming_error 3 5.5s 10.3s
imixv2::bin/imixv2: tests::task_tests::test_task_streaming_error 3 5.5s 10.3s
imixv2::bin/imixv2: tests::task_tests::test_task_streaming_error 3 5.5s 10.3s
imixv2::bin/imixv2: tests::task_tests::test_task_streaming_output 3 5.4s 10.3s
imixv2::bin/imixv2: tests::task_tests::test_task_streaming_output 3 5.4s 10.3s
imixv2::bin/imixv2: tests::task_tests::test_task_streaming_output 3 5.4s 10.3s
eldritch: http::get_impl::tests::test_get_empty_params_and_headers 3 2.1s 6.4s
eldritch: http::get_impl::tests::test_get_empty_params_and_headers 3 2.1s 6.4s
eldritch: http::get_impl::tests::test_get_empty_params_and_headers 3 2.1s 6.4s
eldritch: http::get_impl::tests::test_get_no_params_or_headers 3 2.1s 6.4s

🎉 No failed tests in this run. | 🍂 No flaky tests in this run.

Github Test Reporter by CTRF 💚

🔄 This comment has been updated

Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the committed 83MB tavern binary tavern/tavern

@hulto hulto enabled auto-merge January 10, 2026 00:04
@hulto hulto requested a review from KCarretto January 10, 2026 19:54
Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel pretty strongly about adding a TaskContext to make this cleaner, otherwise lgtm

@hulto hulto requested a review from KCarretto January 15, 2026 03:45
KCarretto
KCarretto previously approved these changes Jan 15, 2026
Copy link
Collaborator

@KCarretto KCarretto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤞

@hulto hulto added this pull request to the merge queue Jan 15, 2026
Merged via the queue into main with commit ad064d8 Jan 15, 2026
8 checks passed
@hulto hulto deleted the add-jwt-keys branch January 15, 2026 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants