Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dimitrie/cnx 643 arcs in blocks are not received #369

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Dimitrie/cnx 643 arcs in blocks are not received #369

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2403288
fix: allows pre-transformation of all ITransformable objects
didimitrie Nov 7, 2024
befb84d
chore: comments
didimitrie Nov 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Connectors/Revit/Speckle.Connectors.RevitShared/Operations/Receive/RevitHostObjectBuilder.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,10 +180,10 @@ CancellationToken cancellationToken
{
using var activity = _activityFactory.Start("BakeObject");

// POC hack of the ages: try to pre transform curves before baking
// POC hack of the ages: try to pre transform curves, points and meshes before baking
// we need to bypass the local to global converter as there we don't have access to what we want. that service will/should stop existing.
if (
localToGlobalMap.AtomicObject is ITransformable transformable and ICurve
localToGlobalMap.AtomicObject is ITransformable transformable // and ICurve
&& localToGlobalMap.Matrix.Count > 0
&& localToGlobalMap.AtomicObject["units"] is string units
)
Expand Down
Loading