Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dimitrie/cnx 643 arcs in blocks are not received #369

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

didimitrie
Copy link
Member

Fixes/improves some lingering issues around blocks to revit:

TLDR, some limitations still apply and most likely will be there for a while:

  • arcs and circles from blocks will not be scalable
  • breps in blocks will not be scalable

Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 8.39%. Comparing base (cac8e1b) to head (befb84d).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #369   +/-   ##
=====================================
  Coverage   8.39%   8.39%           
=====================================
  Files        238     238           
  Lines       4692    4692           
  Branches     512     512           
=====================================
  Hits         394     394           
  Misses      4282    4282           
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@didimitrie didimitrie merged commit bc6f6c4 into dev Nov 7, 2024
5 checks passed
@didimitrie didimitrie deleted the dimitrie/cnx-643-arcs-in-blocks-are-not-received branch November 7, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants