fix(auth/error): improve error handling of auth issues

packages/server/modules/auth/strategies/github.ts

@@ -164,11 +164,12 @@ const githubStrategyBuilderFactory =
             case InviteNotFoundError:
             case UnverifiedEmailSSOLoginError:
               logger.info(err)
-              break
+              return done(null, false, { message: e.message })
             default:
               logger.error(err)
+              // Only when the server is operating abnormally should err be set, to indicate an internal error.
+              return done(err, false, { message: e.message })
           }
-          return done(err, false, { message: e.message })
         }
       }
     )

packages/server/modules/auth/strategies/google.ts

@@ -147,11 +147,12 @@ const googleStrategyBuilderFactory =
             case UserInputError:
             case InviteNotFoundError:
               logger.info({ err: e })
-              break
+              return done(null, false, { message: e.message })
             default:
               logger.error({ err: e })
+              // Only when the server is operating abnormally should err be set, to indicate an internal error.
+              return done(e, false, { message: e.message })
           }
-          return done(e, false, { message: e.message })
         }
       }
     )

packages/server/modules/auth/strategies/local.ts

@@ -23,6 +23,7 @@ import {
   ValidateUserPassword
 } from '@/modules/core/domain/users/operations'
 import { GetServerInfo } from '@/modules/core/domain/server/operations'
+import { UserValidationError } from '@/modules/core/errors/user'
 
 const localStrategyBuilderFactory =
   (deps: {
@@ -69,7 +70,16 @@ const localStrategyBuilderFactory =
 
           return next()
         } catch (err) {
-          req.log.info({ err }, 'Error while logging in.')
+          const e = ensureError(err, 'Unexpected issue occured while logging in')
+          switch (e.constructor) {
+            case UserInputError:
+            case UserValidationError:
+              req.log.info({ err }, 'Error while logging in.')
+              break
+            default:
+              req.log.error({ err }, 'Error while logging in.')
+              break
+          }
           return res.status(401).send({ err: true, message: 'Invalid credentials.' })
         }
       },

packages/server/modules/auth/strategies/oidc.ts

@@ -162,11 +162,12 @@ const oidcStrategyBuilderFactory =
               case UserInputError:
               case InviteNotFoundError:
                 logger.info({ err: e })
-                break
+                return done(null, undefined)
               default:
                 logger.error({ err: e })
+                // Only when the server is operating abnormally should err be set, to indicate an internal error.
+                return done(e, undefined)
             }
-            return done(e, undefined)
           }
         }
       )