fix(auth/error): improve error handling of auth issues #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainsproat
commented
Feb 7, 2025
| req.log.info({ err }, 'Error while logging in.') | ||
| break | ||
| default: | ||
| req.log.error({ err }, 'Error while logging in.') |
There was a problem hiding this comment.
We want to alert on some types of issues when users are logging in, so this adds error level logging for unexpected errors.
| default: | ||
| req.log.error({ err }, 'Error while logging in.') | ||
| break | ||
| } | ||
| return res.status(401).send({ err: true, message: 'Invalid credentials.' }) |
There was a problem hiding this comment.
Question related to this, should we instead be using next(e) and let the error handling middleware then handle how the error is returned to the user?
https://expressjs.com/en/guide/error-handling.html
gjedlicska
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Our logging system showed that some types of errors were being logged twice, the first time as
infolevel and the second aserrorlevel:As this is an user-related error, it should only have been logged as
infolevel. This PR does not yet address the logging duplication, but addresses the logging levels.Some errors we catch should not be passed to the passportjs callback function, and instead it should only be marked as failure.
From documentation https://www.passportjs.org/concepts/authentication/downloads/html/
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References