-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Clarify buildType #875
Conversation
Clarifies the meaning of buildType, as it was unclear. The actual intent was to "namespace" the meaning of a Build element so that the rest of the properties can be interpreted. This matches the SLSA definition of buildType.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor changes. Add full stops at the end of sentences.
* An invocation of a compiler or other tool | ||
* A script that orchestrates builds at a higher level | ||
|
||
Keep in mind that builds can be "nested" using the `ancestorOf` relationship |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep in mind that builds can be "nested" using the `ancestorOf` relationship | |
Keep in mind that builds can be "nested" using the `ancestorOf` relationship. |
|
||
If the buildType IRI is not recognized, it is still possible to inspect other | ||
properties of the build, but it may not be possible to derive deeper meaning | ||
from them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from them | |
from them. |
properties of the build, but it may not be possible to derive deeper meaning | ||
from them | ||
|
||
For more information, see the SLSA definition of buildType |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For more information, see the SLSA definition of buildType | |
For more information, see the SLSA definition of buildType. |
Note: after this PR got merged, need to add ref to SLSA in the Reference chapter: -- SLSA ref was in the Reference before, but was removed by spdx/spdx-spec#1076 as with the merged of #862 there's no citation to SLSA in both spdx-3-model and spdx-spec. The text we were previously used: *SLSA Provenance v0.2*, The Linux Foundation,
[https://slsa.dev/provenance/v0.2](https://slsa.dev/provenance/v0.2). It was between refs to "Semantic Versioning" and "SoftWare Heritage". |
@kestewart @goneall should this update be in 3.0.1 or 3.1 ? |
I would like to get this reviewed by Nisha and Brandon - I'll ping them in email. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed in call, and changes are primarily editorial, so Bob's ok with it.
SLSA reintroduced because of spdx/spdx-3-model#875 Signed-off-by: Arthit Suriyawongkul <arthit@gmail.com>
The bullet is broken, will be fixed by this PR #879 |
Clarifies the meaning of buildType, as it was unclear. The actual intent was to "namespace" the meaning of a Build element so that the rest of the properties can be interpreted. This matches the SLSA definition of buildType.