Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Build.md to remove separate definition of properties #862

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Update Build.md to remove separate definition of properties #862

merged 1 commit into from
Aug 20, 2024

Conversation

lumjjb
Copy link
Collaborator

@lumjjb lumjjb commented Aug 19, 2024

Update Build.md to remove separate definition of properties where it was referencing SLSA v0.2, and to avoid confusion against already defined properties.

@nishakm @JPEWdev

@lumjjb
Update Build.md to remove separate definition of properties
16e036b 
Update Build.md to remove separate definition of properties where it was referencing SLSA v0.2, and to avoid confusion against already defined properties.

Signed-off-by: Brandon Lum <lumjjb@gmail.com>
@lumjjb lumjjb requested a review from goneall August 19, 2024 20:14
@lumjjb lumjjb added this to the 3.0.1 milestone Aug 19, 2024
goneall
goneall approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bact
bact approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

May need to check docs/references.md in spdx/spdx-spec repo as well, if it still ref SLSA 0.2

kestewart
kestewart approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed in call, no objections.

@kestewart kestewart merged commit 773a94d into main Aug 20, 2024
1 check passed
@bact bact mentioned this pull request Aug 20, 2024
Merged
@bact bact deleted the lumjjb-patch-1 branch August 20, 2024 22:26
@bact bact mentioned this pull request Sep 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bact bact bact approved these changes

@goneall goneall goneall approved these changes

@JPEWdev JPEWdev JPEWdev approved these changes

@kestewart kestewart kestewart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.
5 participants
@lumjjb @bact @goneall @JPEWdev @kestewart