-
Notifications
You must be signed in to change notification settings - Fork 26
Generically type ButtonProps #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
WesCossick
merged 19 commits into
sparksuite:master
from
caryaharper:create-type-options-for-button-ref
Jan 19, 2022
Merged
Changes from 3 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8c03960
made hook use generic type to allow for any HTML element, updated tes…
caryaharper 7ba49c9
formatting
caryaharper f2a5670
updated docs to reflect changes
caryaharper 177db00
made docs and readme more specific
caryaharper c4ea103
reverted yarn.lock
caryaharper 9c215c3
attempting to revert again
caryaharper 4030010
fixed useDropdownMenu not being passed a type
caryaharper b270f0a
made useDropDownMenu have a default type as well as fixed issues comi…
caryaharper beeaca5
changed jsx example to use a div as in the above js example
caryaharper 7bb0dd1
removed the example hook being passed a generic type
caryaharper 89df38b
reverted line five due to generic type now being optional
caryaharper 5e6147f
made doc more concise
caryaharper a193d30
reverted line 14 due to HTMLButtonElement now being the default type
caryaharper a3ce0a8
replaced the word class with the word type
caryaharper 7261009
replaced all instances of T being used as a type parameter
caryaharper 9752b50
Update website/docs/design/type-parameters.md
caryaharper b21ca90
Update website/docs/design/type-parameters.md
caryaharper a939103
changed “the menu” to “a”
caryaharper 08c6d54
Merge branch 'create-type-options-for-button-ref' of github.com:carya…
caryaharper File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.