Generically type ButtonProps #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caryaharper
force-pushed
the
create-type-options-for-button-ref
branch
from
8602b96 to
7ba49c9
Compare
caryaharper
changed the title
Codecov Report
@@ Coverage Diff @@
## master #290 +/- ##
==========================================
+ Coverage 90.81% 90.90% +0.09%
==========================================
Files 1 1
Lines 98 99 +1
Branches 32 32
==========================================
+ Hits 89 90 +1
Misses 7 7
Partials 2 2
Continue to review full report at Codecov.
|
corymharper
suggested changes
Nov 16, 2021
|
This pull request should generate no changes to |
corymharper
approved these changes
Nov 17, 2021
corymharper
suggested changes
Nov 17, 2021
corymharper
approved these changes
Nov 17, 2021
corymharper
suggested changes
Nov 17, 2021
There was a problem hiding this comment.
Can you introduce a generic type parameter default of HTMLButtonElement? Then a lot of the documentation won't have to change at all, along with some of the code, and we can add a page of documentation indicating how to use types other than HTMLButtonType for the menu button.
…ng from the change and added a doc
corymharper
suggested changes
Dec 13, 2021
corymharper
suggested changes
Dec 13, 2021
corymharper
approved these changes
Jan 17, 2022
WesCossick
previously requested changes
Jan 17, 2022
Co-authored-by: Wes Cossick <WesCossick@users.noreply.github.com>
Co-authored-by: Wes Cossick <WesCossick@users.noreply.github.com>
…harper/react-accessible-dropdown-menu-hook into create-type-options-for-button-ref
corymharper
dismissed
WesCossick’s stale review
The requested changes have been made
WesCossick
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change requires that a type with the constraint of HTMLElement be passed to useDropdownMenu allowing any HTML element to be used as the “button”.
The purpose of this change is to allow the user to receive buttonProps tailored to their desired HTML element.
Some test were also updated to account for the new requirement of a type being passed to the hook.
Closes #69