Added multilanguage support #39
Conversation
sparksuite#16 sparksuite/simplemde-markdown-editor#658 Read the README to understand how it works
Fix bad variable.
|
Sorry but I don't see your message on github PR. Anyway, I think the
feature is fully implemented now.
Thank you,
Eugenio
Il Mer, 7 Febbraio 2018 3:27 pm, Nicklas Kevin Frank ha scritto:
@eutampieri Want someone to look at this? This seems like a very nice
feature to have.
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#39 (comment)
Eugenio Tampieri
|
|
@eutampieri Hmm, I don't see it either, oh well thanks a lot! We pulled it in with some other business-specific changes, and it seems to be working great. |
|
I am very much interested in this feature. How is the PR going? If you have no plans to incorporate this to the standard bower installation anytime soon, could you give me a hint on how I could compile this branch from source? I tried Right now I can only install the extension through the instructions in Thanks |
|
@gutosurrex I don't know what the development team has decided, I'm not part of this project anyway. I can't answer to the second question either because I've planned to use as a standalone JS file (https://github.com/ETSoftware/codemirror-spell-checker/blob/8df1c17873c93a5e6df76a7a59b880862172bc55/src/js/spell-checker.js) |
|
Hey, is this still considered for validation anyday soon ? Would be a great addition to the library ! |
|
Indeed
Eugenio Tampieri
… Il giorno 6 apr 2019, alle ore 17:04, Tristan Pouliquen ***@***.***> ha scritto:
Hey,
is this still considered for validation anyday soon ? Would be a great addition to the library !
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
@eutampieri I took the liberty to start from your work to update it a little and I opened an issue on this topic on EasyMDE which is a popular and active fork of SimpleMDE and uses this feature : Ionaru/easy-markdown-editor#78 |
|
You did the right thing!
Eugenio Tampieri
… Il giorno 8 apr 2019, alle ore 09:41, Tristan Pouliquen ***@***.***> ha scritto:
@eutampieri I took the liberty to start from your work to update it a little and I opened an issue on this topic on EasyMDE which is a popular and active fork of SimpleMDE and uses this feature : Ionaru/easy-markdown-editor#78
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
ping @kirrok, @WesCossick |
|
This PR seem ready after a rebase. @eutampieri Can you rebase ? |
|
I'll have a look on Monday (hopefully) |
|
It seems to me that only the minified file is conflicting… |
|
This pull request aims to address:
Read the README to understand how it works