Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowing multi language support for spell check #78

Open
TristanPouliquen opened this issue Apr 6, 2019 · 6 comments
Open

Allowing multi language support for spell check #78

TristanPouliquen opened this issue Apr 6, 2019 · 6 comments

Comments

@TristanPouliquen
Copy link

TristanPouliquen commented Apr 6, 2019

Is your feature request related to a problem? Please describe.
I find quite limitating the idea that the spellCheck (coming from CodeMirror SpellChecker ) should only be on the American English dictionary.

Describe the solution you'd like
How hard would it be to fork, take into account the changes from the actually open (and sadly stale) PR sparksuite/codemirror-spell-checker#39 adding multi-language support and depend on this library rather than the official spellChecker (which appears as stale as SimpleMDE) ?

An addition would be to, perhaps, make a map between locales and the dictionaries from titoBozout's repository so that we could simplify the spellChecker attribute to:

  • false to disable totally
  • locale (for managed dictionaries)
  • {aff: string, dic: string} (for custom dictionary as is implemented in the PR linked above)

EDIT

I went on and forked SpellChecker to start what I had in mind ! 😃 : https://github.com/TristanPouliquen/codemirror-spell-checker

@Akirami
Copy link

Akirami commented Apr 21, 2019

How hard would it be to fork

I did it, check my repo for more information.

@smundro
Copy link

smundro commented May 18, 2021

Does #333 (specifying a custom CodeMirrorSpellChecker instance cover this use case?

@Ionaru
Copy link
Owner

Ionaru commented May 23, 2021

@TristanPouliquen

I think #333 will solve your issue, you can use it in the config like this:

const editor = new EasyMDE({
    spellChecker: (editor) => CodeMirrorSpellChecker({codeMirrorInstance: editor}),
});

Where CodeMirrorSpellChecker is your custom spellchecker from https://github.com/TristanPouliquen/codemirror-spell-checker.

The custom spellchecker functionality is currently available on the easymde@next branch and will be released after a few days if it satisfies the use-cases.

@thecocce
Copy link

thecocce commented May 3, 2023

Hi, any news about this feature release? I need to use with a italian language/dict

@Ionaru
Copy link
Owner

Ionaru commented May 10, 2023

#333 was merged and released a while ago. That should allow you to change the spell checker for different languages.

@BLurRPC
Copy link

BLurRPC commented Apr 3, 2024

Hi, do you have a working example ?
I always have "CodeMirror Spell Checker: You must provide an instance of CodeMirror via the option codeMirrorInstance" error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants