Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing semicolon #324

Merged
merged 4 commits into from
Jun 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/workflows/sqlite3-ruby.yml
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,13 @@ jobs:
run: bundle exec rake compile:msys2
- name: test
run: bundle exec rake test

ubuntu:
runs-on: ubuntu-latest
container:
image: ruby:2.7.5-buster # old enough to not support SQLITE_DBCONFIG_DQS_DDL
steps:
- uses: actions/checkout@v3
- run: bundle install
- run: bundle exec rake compile
- run: bundle exec rake test
6 changes: 6 additions & 0 deletions CHANGELOG.rdoc
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
=== 1.4.4 (unreleased)

* Fixes
* Compilation no longer fails against SQLite3 versions < 3.29.0. This issue was introduced in v1.4.3. [#324] (Thank you, @r6e!)


=== 1.4.3 (2022-05-25)

* Enhancements
Expand Down
2 changes: 1 addition & 1 deletion ext/sqlite3/database.c
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ static VALUE rb_sqlite3_disable_quirk_mode(VALUE self)

return Qtrue;
#else
return Qfalse
return Qfalse;
#endif
}

Expand Down
4 changes: 4 additions & 0 deletions test/test_database.rb
Original file line number Diff line number Diff line change
Expand Up @@ -512,6 +512,10 @@ def test_execute_with_named_bind_params
end

def test_strict_mode
unless Gem::Requirement.new(">= 3.29.0").satisfied_by?(Gem::Version.new(SQLite3::SQLITE_VERSION))
skip("strict mode feature not available in #{SQLite3::SQLITE_VERSION}")
end

db = SQLite3::Database.new(':memory:')
db.execute('create table numbers (val int);')
db.execute('create index index_numbers_nope ON numbers ("nope");') # nothing raised
Expand Down