Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing semicolon #324

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Add missing semicolon #324

merged 4 commits into from
Jun 14, 2022

Conversation

r6e
Copy link
Contributor

@r6e r6e commented Jun 13, 2022

Fixes #323

The build fails on the ruby:2.7.5-buster Docker image (and, presumably, other Linux distros using the same build chain) due to a missing semicolon. For some reason, the build does not fail on macOS.

Adding this semicolon allows the build to pass on the ruby:2.7.5-buster image, and it still passes on macOS as well.

@r6e
Copy link
Contributor Author

r6e commented Jun 13, 2022

The build failure looks like a config issue that wouldn't have anything to do with this change. Not really sure what, if anything, I should do about that.

Copy link

@cs278 cs278 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Came here to suggest the same fix.

@casperisfine
Copy link

Thank you

@flavorjones
Copy link
Member

I'm going to first ship a PR that adds a CI job that covers this branch. Please hold.

@flavorjones
Copy link
Member

Success, failing CI: https://github.com/sparklemotion/sqlite3-ruby/runs/6880316208?check_suite_focus=true

I've now added that CI job into this PR. I expect the test for this feature will now fail ...

@flavorjones
Copy link
Member

And added a commit to conditionally skip that test for sqlite < 3.29.0.

[skip ci]
@flavorjones
Copy link
Member

I'll also note that I have a large branch at #320 that cleans up CI and the C extension a bit, which also fixes the appveyor/windows builds, so I'm not worried about those failures right now.

@flavorjones flavorjones merged commit f22b723 into sparklemotion:master Jun 14, 2022
@flavorjones
Copy link
Member

Thank you! I'll poke the folks with gem push privileges to get a release out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native extension fails to build for v1.4.3
4 participants