Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nokogiri's dependency on mini_portile has introduced a dependency on git #1102

Closed
martinb3 opened this issue May 13, 2014 · 8 comments
Closed

Nokogiri's dependency on mini_portile has introduced a dependency on git #1102

martinb3 opened this issue May 13, 2014 · 8 comments

Comments

@martinb3
Copy link

Hello!

Apparently, the new release of nokogiri 1.6.2 installs its own version of various xml libraries, and uses mini_portile, which has an undeclared dependency on git being installed, see flavorjones/mini_portile#32.

If nokogiri is going to use this other project, it needs to declare some sort of git requirement somewhere.

This is likely the root cause for:

#1095
#1100
#1099
#1098

I know you have quite a few other issues open, and this duplicates them, but I wanted to call this out since many of the other issues had specific workarounds (a version of git apply was broken, or a git config setting was breaking things), but the root issue is the undeclared dependency on git.

Thanks!
@martinb3
@justfalter justfalter mentioned this issue May 13, 2014
Closed
@flavorjones
Copy link
Member

Hi,

Thanks for communicating that these are all the same issue ... I'm going to make this the master ticket and close the others.

@flavorjones flavorjones mentioned this issue May 14, 2014
Closed
@flavorjones
Copy link
Member

Note that #1101 is not related.

This was referenced May 14, 2014
Closed
Closed
Closed
flavorjones added a commit that referenced this issue May 14, 2014
@flavorjones
Monkey patching mini_portile. Temporarily addresses #1102.
d015887
@martinb3
Copy link
Author

Removed #1101 from the original list.

flavorjones added a commit that referenced this issue May 14, 2014
@flavorjones
Monkey patching mini_portile. Temporarily addresses #1102.
98b5b83
@flavorjones
Copy link
Member

Just released 1.6.2.1 which should address the git dependency issue for now.

@martinb3
Copy link
Author

Thanks a ton!

@yveslaroche yveslaroche mentioned this issue May 14, 2014
Closed
martinb3 added a commit to martinb3-cookbooks/xml that referenced this issue May 14, 2014
@martinb3
[COOK-4651] Pin nokogiri at a working version
88166e1 
The xml community cookbook has a dependency on nokogiri [1]. However, nokogiri just did a new release [2], and it uses a new version of mini_portile [3], which has a brand new dependency on 'git apply' being a working command.

I have notified the nokogiri project [4], but I also think it's important to pin the xml cookbook to known working versions of dependencies (instead of 'any nokogiri version you can find').

[1] https://github.com/opscode-cookbooks/xml/blob/master/recipes/ruby.rb#L35
[2] https://groups.google.com/forum/#!topic/nokogiri-talk/dPtmByhszRA
[3] flavorjones/mini_portile#32
[4] sparklemotion/nokogiri#1102
@0xdevalias 0xdevalias mentioned this issue Sep 14, 2014
Closed
@gerggggggg
Copy link

I had this problem on CentOS 6 Minimal and the problem was that patch wasn't installed, so a "yum install patch" fixed the problem for me.

@lfender6445
Copy link

👍 gerggggggg - same for me on Amazon Linux AMI v 2014.09

@flavorjones
Copy link
Member

This issue was addressed and closed in May 2014. If you're experiencing an issue now, please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@flavorjones @martinb3 @gerggggggg @lfender6445