Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timeout to gitlab requests in job classification task #895

Merged
merged 2 commits into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/custom_docker_builds.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
- docker-image: ./images/cache-indexer
image-tags: ghcr.io/spack/cache-indexer:0.0.3
- docker-image: ./analytics
image-tags: ghcr.io/spack/django:0.3.1
image-tags: ghcr.io/spack/django:0.3.2
- docker-image: ./images/ci-prune-buildcache
image-tags: ghcr.io/spack/ci-prune-buildcache:0.0.3
- docker-image: ./images/protected-publish
Expand Down
5 changes: 4 additions & 1 deletion analytics/analytics/core/job_failure_classifier/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,10 @@ def _collect_pod_status(job_input_data: dict[str, Any], job_trace: str):
)
def upload_job_failure_classification(job_input_data_json: str) -> None:
gl = gitlab.Gitlab(
settings.GITLAB_ENDPOINT, settings.GITLAB_TOKEN, retry_transient_errors=True
settings.GITLAB_ENDPOINT,
settings.GITLAB_TOKEN,
retry_transient_errors=True,
timeout=15,
)

# Read input data and extract params
Expand Down
4 changes: 2 additions & 2 deletions k8s/production/custom/webhook-handler/deployments.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ spec:
serviceAccountName: webhook-handler
containers:
- name: webhook-handler
image: ghcr.io/spack/django:0.3.1
image: ghcr.io/spack/django:0.3.2
imagePullPolicy: Always
resources:
requests:
Expand Down Expand Up @@ -146,7 +146,7 @@ spec:
serviceAccountName: webhook-handler
containers:
- name: webhook-handler-worker
image: ghcr.io/spack/django:0.3.1
image: ghcr.io/spack/django:0.3.2
command: ["celery", "-A", "analytics.celery", "worker", "-l", "info", "-Q", "celery"]
imagePullPolicy: Always
resources:
Expand Down