Add timeout to gitlab requests in job classification task #895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Soft time limit (60s) exceeded for upload_job_failure_classification
sentry errors seem to be occuring due to the gitlab API requests hanging. The default timeout for them is60
, so if a request hangs for that long, it will exceed the Soft time limit set in the celery task.Adding this timeout of 15 seconds will hopefully confirm this, as I don't see a way to see what's happening using just the sentry errors.