-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-568: remove ModelContainer from datamodels. #204
Merged
mairanteodoro
merged 15 commits into
spacetelescope:main
from
mairanteodoro:RCAL-568-remove-modelcontainer
Jun 9, 2023
Merged
RCAL-568: remove ModelContainer from datamodels. #204
mairanteodoro
merged 15 commits into
spacetelescope:main
from
mairanteodoro:RCAL-568-remove-modelcontainer
Jun 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #204 +/- ##
==========================================
+ Coverage 97.89% 98.05% +0.15%
==========================================
Files 8 8
Lines 1285 1234 -51
==========================================
- Hits 1258 1210 -48
+ Misses 27 24 -3
☔ View full report in Codecov by Sentry. |
PaulHuwe
approved these changes
Jun 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RCAL-568
This PR removes
ModelContainer
fromroman_datamodels.datamodels
.Checklist
CHANGES.rst
under the corresponding subsection