Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RCAL-568: remove ModelContainer from datamodels. #204

Merged

Conversation

mairanteodoro
Copy link
Collaborator

Resolves RCAL-568

This PR removes ModelContainer from roman_datamodels.datamodels.

Checklist

@mairanteodoro mairanteodoro requested a review from nden June 8, 2023 16:46
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.15 🎉

Comparison is base (562040a) 97.89% compared to head (38f911c) 98.05%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #204      +/-   ##
==========================================
+ Coverage   97.89%   98.05%   +0.15%     
==========================================
  Files           8        8              
  Lines        1285     1234      -51     
==========================================
- Hits         1258     1210      -48     
+ Misses         27       24       -3     
Impacted Files Coverage Δ
tests/test_models.py 98.64% <100.00%> (+0.40%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mairanteodoro mairanteodoro marked this pull request as ready for review June 8, 2023 16:47
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mairanteodoro mairanteodoro merged commit 3f003a1 into spacetelescope:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants