Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inverse linearity's reftype #195

Merged

Conversation

WilliamJamieson
Copy link
Contributor

@WilliamJamieson WilliamJamieson commented Jun 2, 2023

This is the matching PR to spacetelescope/rad#272 in order for roman_datamodels to remain compatible with RAD.

Checklist

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.09 ⚠️

Comparison is base (35d7c6b) 98.01% compared to head (e6bb6be) 97.93%.

❗ Current head e6bb6be differs from pull request most recent head 4d6e3be. Consider uploading reports for the commit 4d6e3be to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
- Coverage   98.01%   97.93%   -0.09%     
==========================================
  Files           8        8              
  Lines        1209     1209              
==========================================
- Hits         1185     1184       -1     
- Misses         24       25       +1     
Impacted Files Coverage Δ
tests/test_models.py 98.29% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@WilliamJamieson
Copy link
Contributor Author

I'm leaving this in draft form, simply because its pyproject.toml will need to be updated once the RAD change is merged.

@WilliamJamieson WilliamJamieson marked this pull request as ready for review June 6, 2023 17:37
@WilliamJamieson WilliamJamieson requested a review from a team as a code owner June 6, 2023 17:37
Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@PaulHuwe PaulHuwe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@WilliamJamieson WilliamJamieson merged commit 0e78b01 into spacetelescope:main Jun 6, 2023
@WilliamJamieson WilliamJamieson deleted the bugfix/inverse_linearity branch June 6, 2023 17:47
mairanteodoro pushed a commit to mairanteodoro/roman_datamodels that referenced this pull request Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants