Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish ARM Ansible Docker images (future tag) #2

Merged
merged 1 commit into from
Nov 21, 2022
Merged

Publish ARM Ansible Docker images (future tag) #2

merged 1 commit into from
Nov 21, 2022

Conversation

peterdeme
Copy link
Contributor

@peterdeme peterdeme commented Nov 10, 2022 •
edited
Loading

Description of the change

Publish ARM Ansible Docker images, plus additional sanity test.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality not to work as expected);
  • Other (miscellaneous, GitHub workflow changes, changes to the PR template);

Checklists

Development

  • Parts of this pull request impacting core (user-facing, documented) product functionality have test coverage;

Code review

  • This pull request has a descriptive title and sufficient context for a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer a draft;
  • You have reviewed this Pull Request yourself;

@peterdeme peterdeme requested review from michalg9 and a team November 10, 2022 15:29
@peterdeme peterdeme changed the title Publish ARM Ansible Docker images Publish ARM Ansible Docker images (future tag) Nov 11, 2022
@peterdeme peterdeme force-pushed the publish-arm-images branch 6 times, most recently from 5ef3aa8 to c418ec6 Compare November 11, 2022 17:05
michalg9
michalg9 approved these changes Nov 21, 2022
View reviewed changes
Copy link
Contributor

@michalg9 michalg9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just left one nit related to testing binaries

@peterdeme peterdeme merged commit 6b1a7f5 into future Nov 21, 2022
@peterdeme peterdeme deleted the publish-arm-images branch November 21, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalg9 michalg9 michalg9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterdeme @michalg9