Fix remaining issues in applications and demos from the updated spaceros base image #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is space-ros/space-ros#193 the only blocker here or are we waiting on something else? |
It is, but once that goes in I'll also need to parameterize the base image name for the moveit and nav2 apps. Sorry this isn't moving as quickly as I'd like, been rather distracted lately. |
This was referenced Sep 9, 2024
|
Closing in favor of #189 for access to org packages. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #161.
Sorry for not having this queued up alongside https://github.com/space-ros/space-ros/pull/170/files. There are a few issues to resolve after blowing the base build up that I am working through here. Including fixing references to nonexistent directories and updating environment variables to the standards.