Moveit2 image building issue

[AlexanderRex]

Operating System

Ubuntu 22.04

Installation type

Pulled from Docker Hub

Version or commit hash

0c482ba

RMW Implementation

FastRTPS

Client library (if applicable)

N/A

Steps to reproduce issue

cd moveit2/ && ./build.sh

Expected behavior

Builded docker image of moveit2

Actual behavior

When I am trying to build moveit2 after building spaceros image it shows this error. Seems like ROSDISTRO should be setted as env variable

Backtrace or Console output

##### Building Space ROS/MoveIt2 Docker Image #####

[+] Building 1.1s (13/30)                                                                                                                                                                    docker:default
 => [internal] load build definition from Dockerfile                                                                                                                                                   0.0s
 => => transferring dockerfile: 6.12kB                                                                                                                                                                 0.0s
 => [internal] load metadata for docker.io/osrf/space-ros:latest                                                                                                                                       0.0s
 => [internal] load .dockerignore                                                                                                                                                                      0.0s
 => => transferring context: 2B                                                                                                                                                                        0.0s
 => [internal] load build context                                                                                                                                                                      0.0s
 => => transferring context: 186B                                                                                                                                                                      0.0s
 => [stage-0  1/26] FROM docker.io/osrf/space-ros:latest                                                                                                                                               0.0s
 => CACHED [stage-0  2/26] RUN mkdir /opt/spaceros/src   && vcs import /opt/spaceros/src < /opt/spaceros/exact.repos                                                                                   0.0s
 => CACHED [stage-0  3/26] RUN --mount=type=cache,target=/var/cache/apt,sharing=locked   --mount=type=cache,target=/var/lib/apt,sharing=locked   sudo apt-get update                                   0.0s
 => CACHED [stage-0  4/26] RUN --mount=type=cache,target=/var/cache/apt,sharing=locked   --mount=type=cache,target=/var/lib/apt,sharing=locked   sudo apt-get dist-upgrade -y                          0.0s
 => CACHED [stage-0  5/26] RUN rosdep update                                                                                                                                                           0.0s
 => CACHED [stage-0  6/26] RUN --mount=type=cache,target=/var/cache/apt,sharing=locked   --mount=type=cache,target=/var/lib/apt,sharing=locked   sudo apt install -y   build-essential   clang-format  0.0s
 => CACHED [stage-0  7/26] RUN python3 -m pip install -U   argcomplete   flake8-blind-except   flake8-builtins   flake8-class-newline   flake8-comprehensions   flake8-deprecated   flake8-docstrings  0.0s
 => CACHED [stage-0  8/26] WORKDIR /home/spaceros-user                                                                                                                                                 0.0s
 => ERROR [stage-0  9/26] RUN sudo git clone https://github.com/moveit/moveit2.git -b ${ROSDISTRO} moveit2/src                                                                                         1.0s
------                                                                                                                                                                                                      
 > [stage-0  9/26] RUN sudo git clone https://github.com/moveit/moveit2.git -b ${ROSDISTRO} moveit2/src:                                                                                                    
0.094 Cloning into 'moveit2'...
1.022 fatal: Remote branch moveit2/src not found in upstream origin
------
Dockerfile:94
--------------------
  92 |     # Get the MoveIt2 source code
  93 |     WORKDIR ${HOME_DIR}
  94 | >>> RUN sudo git clone https://github.com/moveit/moveit2.git -b ${ROSDISTRO} moveit2/src
  95 |     RUN cd ${MOVEIT2_DIR}/src \
  96 |       && sudo git clone https://github.com/moveit/moveit2_tutorials.git -b ${ROSDISTRO}
--------------------
ERROR: failed to solve: process "/bin/sh -c sudo git clone https://github.com/moveit/moveit2.git -b ${ROSDISTRO} moveit2/src" did not complete successfully: exit code: 128

[AlexanderRex]

I found why that happened, in Earthly file its ROS_DISTRO, but then in Moveit docker its ROSDISTRO

[Bckempa]

This will be fixed by #162 but is currently blocked by space-ros/space-ros#193.

@EzraBrooks, @eholum, should we split #162 to address this?

[Bckempa]

Also, @AlexanderRex this is a duplicate of #160. You can look there for more info. I'll close this as duplicate for now since it is tracked by #161.