Skip to content

Conversation

@zbeekman
Copy link
Collaborator

coverage on master
Codecov branch

Summary of changes

Get branch up-to-date, and resolve failing CI tests

Rationale for changes

Branch is outdated and is using older CI configurations.

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe: Updating branch with latest changes on master

I certify that

  • I certify that:
    • I have reviewed and followed the contributing guidelines
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

zbeekman and others added 30 commits April 24, 2019 16:06
 - This will be great for making it easier to:
   - Uninstall the package, ensuring that the files are not custom modifications
   - Verify reproducible builds
 - Otherwise, the install receipt will depend on install location, reducing the
   reproducibility of the build!
MPI_Comm_split alone is sufficient to provide the
image-control-statement image ordering semantics required by FORM TEAM.

Implements RFE in issue #630.
 - GFortran 9.1 complains about initializing a precedure pointer to an internal procedure
 - ¯\_(ツ)_/¯
 - This reduces the complexity of the CI infra and makes specifying dependencies easier
 - More testing on macOS should now be enabled using both:
   - Native CMake w/ Apple Clang and OpenMPI builds and
   - The projects Brewfile to build w/ GCC & MPICH
@zbeekman zbeekman requested a review from rouson June 25, 2019 14:19
@stale
Copy link

stale bot commented Jul 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jul 23, 2019
@stale stale bot closed this Aug 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants