Skip to content

Conversation

@zbeekman
Copy link
Collaborator

Summary of changes

Add funding button

Rationale for changes

Help users donate

Additional info and certifications

This pull request (PR) is a:

  • Bug fix
  • Feature addition
  • Other, Please describe: shameless solicitation for money

I certify that

  • I certify that:
    • I have reviewed and followed the [contributing guidelines]
    • I will wait at least 24 hours before self-approving the PR to give another
      OpenCoarrays developer a chance to review my proposed code
    • I have not introduced errant white space (no trailing white space or white space errors may
      be introduced)
    • I have added an explanation of what these changes do and why they should be included
    • I have checked to ensure there aren't other open Pull Requests for the same change
    • I have you written new tests for these changes
    • I have successfully tested these changes locally
    • I have commented any non-trivial, non-obvious code changes
    • The commits are logically atomic, self consistent and coherent
    • The commit messages follow best practices
    • Test coverage is maintained or increased after this is merged

Code coverage data

coverage on master

Copy link
Collaborator Author

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented May 24, 2019

Codecov Report

Merging #670 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #670   +/-   ##
=======================================
  Coverage   54.54%   54.54%           
=======================================
  Files           3        3           
  Lines        2924     2924           
=======================================
  Hits         1595     1595           
  Misses       1329     1329

@zbeekman zbeekman merged commit cf84092 into master May 24, 2019
@zbeekman zbeekman deleted the zbeekman-funding-yml branch May 24, 2019 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants