Issue 42 ns fails #194
Closed
Issue 42 ns fails #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbeekman
force-pushed
the
issue-42-NS-fails
branch
from
297362b to
63f9885
Compare
Current coverage is 49.72%@@ master #194 diff @@
==========================================
Files 2 2
Lines 895 895
Methods 42 42
Messages 0 0
Branches 149 149
==========================================
Hits 445 445
Misses 450 450
Partials 0 0
|
zbeekman
force-pushed
the
issue-42-NS-fails
branch
2 times, most recently
from
63f9885 to
47d28bd
Compare
zbeekman
force-pushed
the
issue-42-NS-fails
branch
from
47d28bd to
6b47189
Compare
|
Once tests pass merge this, then merge #195 |
|
Actually, much simpler to just merge #195 and close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a typo that I introduced in c7022fe which may be responsible for #42.
I have fixed the typo, and re-enabled the NS tests on Travis-CI in hopes that they now pass.