Use modern GitLab URLs #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
If you require a CLA for this repository, feel free to close this PR. I'm fine with contributing to Zoekt under the original license this project was released under (Apache 2.0, as described in the LICENSE file), but I won't read or sign some legal document just to contribute 2 lines of code. PS: In my own jurisdiction (Germany), this change probably isn't copyrightable anyways (Schöpfungshöhe), so feel free to close this PR and include the change without attributing me. |
|
Hey @TobiX, the CLA bot integration was mistakenly added to this repository and signing the CLA is indeed not required - I've removed the integration and you can safely ignore the comments and CLA check |
|
Thanks @TobiX for bringing this to our attention. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have no idea when GitLab started using this URL scheme, but all modern GitLab instances I have access to use this URL pattern.
The old scheme still works, but leads to some UI problems (for example, the branch drop-down is broken), see for comparison:
Try to switch to the
masterbranch on both and see how you loose the file path in the old URL