Make IndexGitRepo signal whether there were changes #781
Conversation
|
We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added. Sourcegraph teammates should refer to Accepting contributions for guidance. |
|
Hmm, I've contributed in the past without signing that. |
I'll be honest I don't know much about these things, let me check in. |
As described, we'd like this information to be externally available to drive metrics for incremental indexing. Closes sourcegraph#780.
isker
force-pushed
the
gitindex-up-to-date
branch
from
f391f3e to
3066e30
Compare
|
We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added. Sourcegraph teammates should refer to Accepting contributions for guidance. |
|
Sorry about those test failures, to be honest I thought |
|
@keegancsmith ping |
|
@isker sorry for the slow response!! We require a CLA for Zoekt contributions too. I can merge right after it's signed. |
|
@jtibshirani Please help me understand. This has not been required for my and others' previous contributions, and it of course was not required for contributions to the project as it existed before sourcegraph took ownership. The project has in fact already seen a situation like this where the CLA requirement was determined to be a mistake (presumably because it was blanket applied to the sourcegraph org?): #409 (comment). You're saying this is not a mistake this time? cc @jdorfman. |
|
@isker looking into this now. |
|
@isker Update: I reached out to legal to understand why your past 7 commits were CLA-free. I will follow up ASAP. |
|
My past commits were CLA-free because there was no requirement to sign a CLA, and indeed you removed that requirement after it was briefly added for a time: #409 (comment). It is the same for any other past contributor to the project; it has nothing to do with me in particular. |
|
Thanks. This otherwise just needs somebody to merge 🌞. |
|
@keegancsmith @jtibshirani, you can override and merge this while I deal with legal. If someone asks you why, you can link back to this very comment. :) @isker thanks so much for your contribution. I apologize for the unpleasant experience. That's on me. |
As described, we'd like this information to be externally available to drive metrics for incremental indexing.
Closes #780.