add output flag for advise #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdpleiness
reviewed
May 30, 2023
Contributor
jdpleiness
left a comment
jdpleiness
left a comment
There was a problem hiding this comment.
I'm having the same issue as in 988 so I am unable to really test the output feature.
- universal config object across all scout tools - kube package for doing repetitve k8s actions
jasonhawkharris
force-pushed
the
jhh/scout-advise
branch
from
af3aecb to
bde2f5f
Compare
jasonhawkharris
force-pushed
the
jhh/scout-advise-output-flag
branch
from
12a55ea to
6c22a21
Compare
jasonhawkharris
force-pushed
the
jhh/scout-advise-output-flag
branch
from
6c22a21 to
52d9599
Compare
jdpleiness
approved these changes
Jun 7, 2023
Contributor
jdpleiness
left a comment
jdpleiness
left a comment
There was a problem hiding this comment.
Looks good overall, just a few fixes.
Co-authored-by: Jacob Pleiness <jdpleiness@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #988.
Test plan
Manually test output command for single pod output and cluster wide.