-
Notifications
You must be signed in to change notification settings - Fork 70
scout/advise: first iteration of the src scout advise subcommand
#988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bb3c14f to
a972390
Compare
src scout advise subcommand
a583db6 to
d1b3f20
Compare
|
video: |
jdpleiness
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- universal config object across all scout tools - kube package for doing repetitve k8s actions
af3aecb to
bde2f5f
Compare
|
I have tested this on I believe that something is happening with Kind, but I have doubts about any of our customers that would use scout would need it to work in a k8s testing environment like Kind. Since it is working in the other deployments, I think this should be merged. |
jdpleiness
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with the new testing.

Refactor
kubepackage for repetitive kubernetes actions across sub commandsFirst iteration of
scout adviseTest plan
Ships with unit tests. Manually tested on healthy and unhealthy instances of sourcegraph (k8s and Docker).