Skip to content

Conversation

@jasonhawkharris
Copy link
Contributor

@jasonhawkharris jasonhawkharris commented May 26, 2023

Refactor

  • create a universal config object for the scout tool
  • before, each subcommand had its own config type
  • add kube package for repetitive kubernetes actions across sub commands

First iteration of scout advise

  • scout advise gives recommendations for resources allocations based on current usage

Test plan

Ships with unit tests. Manually tested on healthy and unhealthy instances of sourcegraph (k8s and Docker).

@jasonhawkharris jasonhawkharris changed the title scout: large scale refactor scout: refactor May 26, 2023
@jasonhawkharris jasonhawkharris force-pushed the jhh/scout-advise branch 2 times, most recently from bb3c14f to a972390 Compare May 27, 2023 16:57
@jasonhawkharris jasonhawkharris marked this pull request as draft May 27, 2023 17:00
@jasonhawkharris jasonhawkharris changed the title scout: refactor scout/advise: first iteration of the src scout advise subcommand May 27, 2023
@jasonhawkharris jasonhawkharris marked this pull request as ready for review May 27, 2023 19:33
@jasonhawkharris
Copy link
Contributor Author

jasonhawkharris commented May 27, 2023

video: src scout advise --namespace ns-sourcegraph --pod gitserver-0
https://github.com/sourcegraph/src-cli/assets/62355966/a3875a98-d856-454e-9919-ae7d28d2555c

@jasonhawkharris jasonhawkharris marked this pull request as draft May 27, 2023 21:41
@jasonhawkharris jasonhawkharris marked this pull request as ready for review May 29, 2023 14:30
Copy link
Contributor

@jdpleiness jdpleiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am having some issues trying this out with a local Helm deployment running in Kind. Am I missing something?
Screenshot 2023-05-30 at 10 42 29 AM

@jasonhawkharris
Copy link
Contributor Author

I have tested this on
✅ Minikube
✅ GCP GKE
✅ AWS AMI
❌ Kind

I believe that something is happening with Kind, but I have doubts about any of our customers that would use scout would need it to work in a k8s testing environment like Kind. Since it is working in the other deployments, I think this should be merged.

Copy link
Contributor

@jdpleiness jdpleiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the new testing.

@jasonhawkharris jasonhawkharris merged commit 23e8eb2 into main Jun 6, 2023
@jasonhawkharris jasonhawkharris deleted the jhh/scout-advise branch June 6, 2023 16:47
@jasonhawkharris jasonhawkharris restored the jhh/scout-advise branch June 7, 2023 17:29
@keegancsmith keegancsmith deleted the jhh/scout-advise branch November 11, 2025 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants