This repository was archived by the owner on Sep 30, 2024. It is now read-only.
codeintel: allow configuring max concurrency in uploads #56117
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strum355
added
team/graph
Contributor
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff 5c7e13f...3a44a08.
|
burmudar
approved these changes
Aug 28, 2023
jhchabran
added a commit
that referenced
this pull request
Aug 29, 2023
…)" This reverts commit de4d547.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our HTTP endpoints have a hard-coded timelimit of 75s. On slower connections with multipart uploads, it is possible for the bandwidth congestion of the competing upload parts to result in the upload failing due to any part taking longer than 75s to upload.
This PR adds a new toggleable to configure the number of parts to be uploaded concurrently, so reduce the congestion/competing between parts.
Test plan
Tested in combination with src-cli over at sourcegraph/src-cli#1023