Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@philipp-spiess
Copy link
Contributor

Fireworks have added llama code base model support for us.

Test plan

  • Only adding a new code completion model string

@philipp-spiess philipp-spiess requested review from a team and eseliger August 29, 2023 08:43
@philipp-spiess philipp-spiess self-assigned this Aug 29, 2023
@cla-bot cla-bot bot added the cla-signed label Aug 29, 2023
@github-actions github-actions bot added the team/code-exploration Issues owned by the Code Exploration team label Aug 29, 2023
@sourcegraph-bot
Copy link
Contributor

sourcegraph-bot commented Aug 29, 2023

📖 Storybook live preview

@philipp-spiess
Copy link
Contributor Author

@valerybugakov @BolajiOlajide Does either of you know how I can fix this Go dependency issue? 🤔

diff --git a/deps.bzl b/deps.bzl
--
  | index 9165b72e0d9..5284fd32eec 100644
  | --- a/deps.bzl
  | +++ b/deps.bzl
  | @@ -6177,8 +6177,8 @@ def go_dependencies():
  | ],
  | build_file_proto_mode = "disable_global",
  | importpath = "github.com/sourcegraph/conc",
  | -        sum = "h1:96VpOCAtXDCQ8Oycz0ftHqdPyMi8w12ltN4L2noYg7s=",
  | -        version = "v0.2.0",
  | +        sum = "h1:OQTbbt6P72L20UqAkXXuLOj79LfEanQ+YQFNpLA9ySo=",
  | +        version = "v0.3.0",
  | )
  | go_repository(
  | name = "com_github_sourcegraph_go_ctags",
  | Uploading annotations | 0s
  | include_names=false, annotate_opts=-t warning
  | handling ./annotations/bazel-prechecks.md
  | 2023-08-29 08:44:50 INFO   Reading annotation body from STDIN
  | 2023-08-29 08:44:50 INFO   Reading annotation body from STDIN

@philipp-spiess
Copy link
Contributor Author

bazel run //:gazelle-update-repos

Did the trick!

@BolajiOlajide
Copy link
Contributor

bazel run //:gazelle-update-repos

Did the trick!

Awesome.
I'm surprised this wasn't caught in #56117.

@philipp-spiess philipp-spiess enabled auto-merge (squash) August 29, 2023 09:10
@philipp-spiess philipp-spiess force-pushed the ps/fireworks-llama-v2-13b-code-instruct branch from 8c98020 to 692572e Compare August 30, 2023 08:30
@philipp-spiess philipp-spiess merged commit 7d1ca95 into main Aug 30, 2023
@philipp-spiess philipp-spiess deleted the ps/fireworks-llama-v2-13b-code-instruct branch August 30, 2023 08:48
Comment on lines 50 to +54
fallthrough
case "fireworks/accounts/fireworks/models/starcoder-1b-w8a16":
fallthrough
case "fireworks/accounts/fireworks/models/llama-v2-13b-code":
fallthrough
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go pro tip (no need to change, just thought it might be interesting):

switch a {
case "A", "B", "C": return true
}

is a bit less verbose and more idiomatic :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice, yes that is prettier to read, I wasn't aware this syntax existed 🙈

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla-signed team/code-exploration Issues owned by the Code Exploration team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants