Conversation
Closed
olafurpg
force-pushed
the
windows
branch
5 times, most recently
from
6781c84 to
9afea4f
Compare
Previously, we didn't test lsif-java on Windows resulting in bugs like #422. This commit adds a build matrix to our CI job and fixes path escaping logic so that it should work correctly on Windows.
olafurpg
force-pushed
the
windows
branch
3 times, most recently
from
4e73d04 to
a26a75d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we didn't test lsif-java on Windows resulting in bugs like
#422. This PR fixes a few of those
bugs but we can't verify that everything works as 100% on Windows because
the CI job was timing out on Windows for reasons I don't understand.
Test plan
Add a Windows CI job, see the failures, fix the errors, see new errors, repeat until the CI job
stops failing but times out. We couldn't merge the PR with an infinite Windows CI job, but we're
confident that we fixed a least a few bugs that previously affected Windows users.